Update embedded webview to share process pool #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unpluggedk
requested review from
antrix1989,
jasoncoolmax,
rohitnarula7176 and
oldalton
jasoncoolmax
approved these changes
Sep 28, 2018
oldalton
approved these changes
Sep 28, 2018
IdentityCore/src/webview/embeddedWebview/ui/mac/MSIDWebviewUIController.m
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WKWebView caching update, applies to both iOS and macOS.
For session cookies, WKWebView’s caching is per process pool. This process pool is created per configuration.
Thus, in order for us to have our SDK treat session as per app launch, we should either have WKProcessPool or configuration static.
Having config static makes sense as this config really shouldn't change per app launch.
If one wants to change this, they will have to use passed in webview.