Skip to content

Commit

Permalink
Fixing api compat issues for 5.2.0 rel :) (#122)
Browse files Browse the repository at this point in the history
* bump versions

* delete suppressions file

* re-generate supressions file

* rm package version

* change baseline package validation

* add back package version

* fixing api compat hopefully

* add version -local to client semver
  • Loading branch information
kellyyangsong authored Apr 18, 2024
1 parent 8faf618 commit 7985a4f
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 23 deletions.
4 changes: 2 additions & 2 deletions Directory.Build.props
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>
<PropertyGroup>
<!--This should be passed from the VSTS build-->
<ClientSemVer Condition="'$(ClientSemVer)' == ''">1.0.0-local</ClientSemVer>
<ClientSemVer Condition="'$(ClientSemVer)' == ''">5.2.0-local</ClientSemVer>
<!--This will generate AssemblyVersion, AssemblyFileVersion and AssemblyInformationVersion-->
<Version>$(ClientSemVer)</Version>

Expand All @@ -26,7 +26,7 @@
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<Nullable>enable</Nullable>
<LangVersion>12</LangVersion>
<PackageVersion>5.1.0</PackageVersion>
<PackageVersion>$(ClientSemVer)</PackageVersion>
<EnablePackageValidation>true</EnablePackageValidation>
<PackageValidationBaselineVersion>5.0.0</PackageValidationBaselineVersion>
</PropertyGroup>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,27 +1,7 @@
<?xml version="1.0" encoding="utf-8"?>
<!-- https://learn.microsoft.com/en-us/dotnet/fundamentals/package-validation/diagnostic-ids -->
<Suppressions xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xmlns:xsd="http://www.w3.org/2001/XMLSchema">
<Suppression>
<DiagnosticId>CP0003</DiagnosticId>
<Target>Microsoft.Identity.Abstractions, Version=1.0.0.0, Culture=neutral, PublicKeyToken=0a613f4dd989e8ae</Target>
<Left>lib/net462/Microsoft.Identity.Abstractions.dll</Left>
<Right>lib/net462/Microsoft.Identity.Abstractions.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0003</DiagnosticId>
<Target>Microsoft.Identity.Abstractions, Version=1.0.0.0, Culture=neutral, PublicKeyToken=0a613f4dd989e8ae</Target>
<Left>lib/netstandard2.0/Microsoft.Identity.Abstractions.dll</Left>
<Right>lib/netstandard2.0/Microsoft.Identity.Abstractions.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>
<Suppression>
<DiagnosticId>CP0003</DiagnosticId>
<Target>Microsoft.Identity.Abstractions, Version=1.0.0.0, Culture=neutral, PublicKeyToken=0a613f4dd989e8ae</Target>
<Left>lib/netstandard2.1/Microsoft.Identity.Abstractions.dll</Left>
<Right>lib/netstandard2.1/Microsoft.Identity.Abstractions.dll</Right>
<IsBaselineSuppression>true</IsBaselineSuppression>
</Suppression>

<Suppression>
<DiagnosticId>CP0006</DiagnosticId>
<Target>M:Microsoft.Identity.Abstractions.IDownstreamApi.PatchForAppAsync``1(System.String,``0,System.Action{Microsoft.Identity.Abstractions.DownstreamApiOptionsReadOnlyHttpMethod},System.Threading.CancellationToken)</Target>
Expand Down

0 comments on commit 7985a4f

Please sign in to comment.