Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows server to execute CLIENT_AND_SERVER commands #164

Merged
merged 1 commit into from
Jan 26, 2025

Conversation

akxcv
Copy link
Contributor

@akxcv akxcv commented Jan 26, 2025

Currently, even though some commands are marked as CLIENT_AND_SERVER, because of the IsValidPlayer check, only the client is able to execute them.

With my changes, the server is now able to execute these commands, too.

As a real usage example, this change allows to circumvent the issue with loading/unloading Retakes Plugin on demand. Sure, this is might not be a "proper" fix for this issue, but it's the one that works for me, and it also fixes a seeming inconsistency in the code.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@B3none B3none merged commit 17aa3df into B3none:master Jan 26, 2025
5 checks passed
@B3none
Copy link
Owner

B3none commented Jan 26, 2025

This change makes sense, thanks! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants