Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SourceCatalog #119

Merged
merged 5 commits into from
Sep 18, 2024
Merged

Add SourceCatalog #119

merged 5 commits into from
Sep 18, 2024

Conversation

moeyensj
Copy link
Member

We've been discussing consolidating our input type definitions across ADAM-ETL, THOR, the impact project, etc.. This PR adds a de-normalized and flattened input type called SourceCatalog with methods to convert subsets of its columns into the more compute-oriented types.

I think we will also want to add an "Observations" type that stores the relevant subset columns in their appropriate SubTable types. So something like:

class Observations(qv.Table):
    id = qv.LargeStringColumn()
    coordinates = SphericalCoordinates.as_column()
    observers = Observers.as_column()
    ... etc

    def from_source_catalog(cls, source_catalog):
         ...

This is still a WIP.

Copy link
Contributor

@akoumjian akoumjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked at precovery indexing and this should work fine for it.
Do we want a method to get the healpixel at a certain resolution? Or does that better belong on SphericalCoordinates?

@moeyensj
Copy link
Member Author

I think attaching it to SourceCatalog is totally fine.

@moeyensj moeyensj force-pushed the jm/source-catalog branch 5 times, most recently from f273039 to aff459b Compare September 18, 2024 16:58
@moeyensj moeyensj changed the title Add SourceCatalog [WIP] Add SourceCatalog Sep 18, 2024
@moeyensj moeyensj merged commit d27d19f into main Sep 18, 2024
3 checks passed
@moeyensj moeyensj deleted the jm/source-catalog branch September 18, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants