This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to update the
jenkins-slave-zap
image.Notable changes:
python-owasp-zap-v2.4
will be pulled-in (same package name as before)Recommendation for release: when building and releasing the new image, it would be a good idea to tag the
jenkins-slave-zap
images with the corresponding versions of SonarQube (existing version would be6
, the new version would be7
) as it is not guaranteed that using different versions on the SonarQube server and the slave will yield successful results.I had mixed success when testing, I believe an old version of the slave with a new version of the SonarQube server may work, but it is not true the other way around.
Tagging versions would allow users to pick their combination of server and jenkins-slave images to use.
Tagging @WadeBarnes for review, not sure who else needs to be involved to build and publish a new image.