Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] 시간표 학기 API 마이그레이션 #557

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from

Conversation

nodobi
Copy link
Contributor

@nodobi nodobi commented Mar 5, 2025

개요

  • 시간표의 학기 API 가 v3 버전으로 변경되었습니다

작업 내용

  • DTO 가 변경됨에 따라 Data, Domain 의 모델을 변경했습니다
    • 마이그레이션 작업 완료 유무를 확인하기 위해 v3 디렉토리를 추가했습니다
  • 의미가 모호한 이름을 직관적으로 변경했습니다
    • getSemesterCheck -> getUserSemesters
    • term -> season
  • lint workflow 에서 local.properties 가 존재하지 않아 발생하는 오류를 수정했습니다

@nodobi nodobi self-assigned this Mar 5, 2025
@nodobi nodobi requested a review from a team as a code owner March 5, 2025 06:01
Copy link
Collaborator

@kongwoojin kongwoojin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
저 코멘트 하나만 확인해주시면 될거 같아요!

  • local properties도 같이 고쳐주셨네요! 감사합니다!

Comment on lines +20 to +23
"1학기" -> Season.Spring
"여름학기" -> Season.Summer
"2학기" -> Season.Fall
"겨울학기" -> Season.Winter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum class Season(val value: String) {
    Spring("1학기"),
    Summer("여름학기")
    ...
}

Semester(
    year = this.year,
    season = Season.entries.find { it.value == this.term } ?: // find 실패
)

요런 느낌으로 줄여서 사용할 수도 있을거같아용

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants