-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BHoM_Engine: Exclude SpecialName methods from BhoMMethodList #3464
base: develop
Are you sure you want to change the base?
BHoM_Engine: Exclude SpecialName methods from BhoMMethodList #3464
Conversation
This excludes: Property.Get and .set Event.Add and .Remove
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
The check |
Issues addressed by this PR
Closes #3461
Explude
IsSpecialName
from being added to the BHoMMethodList. This excludes Proeprty get and sets, from Properties in the engine. Also excludes Add and Remove methods for events.This relates to these PRs:
BHoM/Versioning_Toolkit#276
BHoM/Versioning_Toolkit#281
Test files
Run the testscript on develop, internalise the results, then re-run on branch and check that the items removed make sense. @pawelbaran quite a few Revit types flagged, so good to make sure you are happy with the removal of them, and that they are not required to be in the BHoMMethod list for anything revit-related (assume not, but want to double check)
Test script on sharepoint
Changelog
Additional comments