Python: Init Beam Distributions #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ax3l
force-pushed
the
py-beam-distribution
branch
2 times, most recently
from
9d594f7 to
7de11d5
Compare
ax3l
force-pushed
the
py-beam-distribution
branch
from
7de11d5 to
bfd7bf8
Compare
Make sure that particles are initialized and otherwise error out cleanly with an exception.
Not needed here yet.
AMReX formatting with extra space
ax3l
force-pushed
the
py-beam-distribution
branch
2 times, most recently
from
269f547 to
e5cd6c6
Compare
Add a variant for all distributions
ax3l
changed the title
ax3l
force-pushed
the
py-beam-distribution
branch
from
e5cd6c6 to
c763527
Compare
ax3l
commented
Jul 22, 2022
| @@ -267,6 +209,7 @@ namespace impactx | |||
| refPart.z = 0.0; | |||
| refPart.px = 0.0; | |||
| refPart.py = 0.0; | |||
| // make the next two lines a helper function? | |||
There was a problem hiding this comment.
@cemitch99 we could make this a helper member function in RefPart, what do you think?
There was a problem hiding this comment.
Discussed on Slack: same for "set_energy_MeV", "get_beta", "get_gamma", etc.?
Yes, I agree this sounds good.
-> will be a separate PR
ax3l
force-pushed
the
py-beam-distribution
branch
from
c763527 to
c1ccf7e
Compare
This makes scripting workflows less verbose. One can still manually initialize AMReX, but users can also rely on defaults now.
for more information, see https://pre-commit.ci
Add argument names to `distribution.generate_add_particles`
ax3l
force-pushed
the
py-beam-distribution
branch
from
f43f679 to
74323c2
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #93
Follow up to #123
AddParticles