Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced config files for RSV and a new lablog for results in viralrecon template #149

Merged
merged 14 commits into from
Aug 22, 2023

Conversation

Shettland
Copy link
Member

Several config files were included in viralrecon template: multiqc_config.yml, viralrecon_rsv.config and viralrecon_rsv_params.yml.

Some implementations were introduced into the results lablog to work for more than one reference, and a new script excel_generator.py was included to process the results. The old lablog was deleted.

Copy link
Member

@svarona svarona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisa los comentarios porfa!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

El fichero de RESULTS se tiene que llamar viralrecon_lablog o viralrecon results porque puede haber más de un servicio que se esté entregando y si todos se llaman lablog se sobre-escriben, igual que en ANALISIS, cambiale el nombre

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Entendido, ahora lo cambio.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puedes añadir a los templates un template del samples_ref de ANALYSIS y un template del reference_file necesario para lanzar el excel_generator?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Si, les pongo ejemplos con nombres reales o algo como "sample" "reference" "host" ?

@Shettland Shettland merged commit 4d05eee into BU-ISCIII:develop Aug 22, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants