Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fixes in autoclean_sftp and bioinfo-doc. Reverted excel_generator.py #208

Merged
merged 7 commits into from
Mar 11, 2024

Conversation

Shettland
Copy link
Member

PR checklist

  • I included small fixes in autoclean_sftp and bioinfo-doc modules that appeared with the new release 2.0.0. Also included a new user in sftp_user.json and reverted excel_generator.py to its previous state with an argument to indicate when to merge lineage tables, as the latest changes were not flexible for those situations where there is no reason to merge them.
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

@saramonzon saramonzon merged commit c746d4f into BU-ISCIII:develop Mar 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants