Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed for multiple service handling and fixed in_progress update #288

Merged
merged 15 commits into from
Jun 27, 2024

Conversation

svarona
Copy link
Member

@svarona svarona commented Jun 25, 2024

Changes:

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

@svarona svarona changed the title Allowed for multiple_service handling and fixed in_progress update Allowed for multiple service handling and fixed in_progress update Jun 25, 2024
bu_isciii/clean.py Outdated Show resolved Hide resolved
bu_isciii/new_service.py Outdated Show resolved Hide resolved
@svarona svarona requested a review from Shettland June 27, 2024 08:30
Copy link
Member

@Shettland Shettland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@svarona svarona merged commit 387e4f4 into BU-ISCIII:develop Jun 27, 2024
2 checks passed
@svarona svarona deleted the multiple_service branch June 27, 2024 08:50
@Daniel-VM Daniel-VM removed their request for review June 27, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants