Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated MAG lablogs and utils.py #334

Merged
merged 4 commits into from
Sep 11, 2024

Conversation

victor5lm
Copy link
Contributor

@victor5lm victor5lm commented Sep 11, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • Make sure your code lints (black and flake8).
  • If a new tamplate was added make sure:
    • Template's schema is added in templates/services.json.
    • Template's pipeline's documentation in assets/reports/md/template.md is added.
    • Results Documentation in assets/reports/results/template.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).
  • If you know a new user was added to the SFTP, make sure you added it to templates/sftp_user.json

PR description

This PR addresses #333. Furthermore, some small modifications have been added to the get_md5() function in utils.py. sftp_user.json has also been updated.

@victor5lm victor5lm marked this pull request as ready for review September 11, 2024 09:09
@victor5lm victor5lm merged commit 3c3c5ba into BU-ISCIII:develop Sep 11, 2024
2 checks passed
@victor5lm victor5lm deleted the small_changes branch October 24, 2024 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants