Define the proper type for the SolariumAdapter #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adapter is always working with Solarium's DocumentInterface so it does not need to be generic.
stof
commented
Dec 13, 2024
| * @param int<0, max> $offset | ||
| * @param int<0, max> $length | ||
| * | ||
| * @return iterable<array-key, T> |
There was a problem hiding this comment.
instead of updating those phpdoc types (replacing T with DocumentInterface), I chose to remove it entirely. They are not necessary as phpstan will properly inherit this info from the AdapterInterface.
|
The current phpstan failure is unrelated to this PR (and is fixed in #58) |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapter is always working with Solarium's DocumentInterface so it does not need to be generic.