Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KHR_node_visibility #15754

Merged
merged 3 commits into from
Oct 30, 2024
Merged

KHR_node_visibility #15754

merged 3 commits into from
Oct 30, 2024

Conversation

RaananW
Copy link
Member

@RaananW RaananW commented Oct 30, 2024

Adding the implementation of KHR_node_visibilityAs per specs in this PR - KhronosGroup/glTF#2410

Vis test added to make sure we support the current specs.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 30, 2024

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 30, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 30, 2024

@bjsplat
Copy link
Collaborator

bjsplat commented Oct 30, 2024

@ryantrem
Copy link
Member

This new extension should be added to packages/dev/loaders/src/glTF/2.0/Extensions/dynamic.ts as well.

@RaananW RaananW enabled auto-merge (squash) October 30, 2024 17:40
@RaananW RaananW merged commit 01f82d0 into BabylonJS:master Oct 30, 2024
11 of 12 checks passed
@RaananW RaananW deleted the khr_node_visibility branch October 30, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants