Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebGPU: Fix GPU buffers update when parameters are not aligned #16110

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

WebGPU: Fix GPU buffers update when parameters are not aligned #16110

wants to merge 4 commits into from
+80 −26

Conversation

Popov72
Copy link
Contributor

@Popov72 Popov72 commented Jan 27, 2025

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Please make sure to label your PR with "bug", "new feature" or "breaking change" label(s).
To prevent this PR from going to the changelog marked it with the "skip changelog" label.

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Snapshot stored with reference name:
refs/pull/16110/merge

Test environment:
https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16110/merge/index.html

To test a playground add it to the URL, for example:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16110/merge/index.html#WGZLGJ#4600

Links to test babylon tools with this snapshot:

https://playground.babylonjs.com/?snapshot=refs/pull/16110/merge
https://sandbox.babylonjs.com/?snapshot=refs/pull/16110/merge
https://gui.babylonjs.com/?snapshot=refs/pull/16110/merge
https://nme.babylonjs.com/?snapshot=refs/pull/16110/merge

To test the snapshot in the playground with a playground ID add it after the snapshot query string:

https://playground.babylonjs.com/?snapshot=refs/pull/16110/merge#BCU1XR#0

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16110/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16110/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16110/merge/testResults/webgl2playwright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Jan 27, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16110/merge/testResults/webgpuplaywright/index.html

@Popov72 Popov72 marked this pull request as draft January 27, 2025 13:17
@bjsplat
Copy link
Collaborator

bjsplat commented Feb 12, 2025

Visualization tests for WebGPU

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16110/merge/testResults/webgpuplaywright/index.html

@bjsplat
Copy link
Collaborator

bjsplat commented Feb 12, 2025

WebGL2 visualization test reporter:

https://snapshots-cvgtc2eugrd3cgfd.z01.azurefd.net/refs/pull/16110/merge/testResults/webgl2playwright/index.html

@Popov72 Popov72 marked this pull request as ready for review February 13, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltakosh deltakosh deltakosh approved these changes

Assignees
No one assigned
Labels
bug WebGPU
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Popov72 @bjsplat @deltakosh