Merge pull request #963 from Backblaze/misc_cleanup

Misc cleanup
Backblaze · Nov 29, 2023 · 179c1bc · 179c1bc
2 parents 9b3d700 + 0e33ad6
commit 179c1bc
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 23 deletions.
diff --git a/.github/workflows/cd.yml b/.github/workflows/cd.yml
@@ -6,7 +6,6 @@ on:
 
 env:
   CD: "true"
-  ACTIONS_STEP_DEBUG: ${{ secrets.ACTIONS_STEP_DEBUG }}
   GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
   PYTHON_DEFAULT_VERSION: "3.12"
 
@@ -41,7 +40,7 @@ jobs:
         with:
           name: ${{ steps.build.outputs.version }}
           body: ${{ steps.read-changelog.outputs.changes }}
-          draft: ${{ env.ACTIONS_STEP_DEBUG == 'true' }}
+          draft: false
           prerelease: false
           files: ${{ steps.build.outputs.asset_path }}
       - name: Upload the distribution to PyPI
@@ -80,7 +79,7 @@ jobs:
         uses: softprops/action-gh-release@v1
         with:
           name: ${{ needs.deploy.outputs.version }}
-          draft: ${{ env.ACTIONS_STEP_DEBUG == 'true' }}
+          draft: false
           prerelease: false
           files: ${{ steps.sign.outputs.asset_path }}
   deploy-windows-bundle:
@@ -120,6 +119,6 @@ jobs:
         uses: softprops/action-gh-release@v1
         with:
           name: ${{ needs.deploy.outputs.version }}
-          draft: ${{ env.ACTIONS_STEP_DEBUG == 'true' }}
+          draft: false
           prerelease: false
           files: ${{ steps.sign.outputs.asset_path }}
diff --git a/b2/console_tool.py b/b2/console_tool.py
@@ -4098,25 +4098,6 @@ def _setup_logging(cls, args, argv):
 get_parser = functools.partial(B2.create_parser, for_docs=True)
 
 
-# TODO: import from b2sdk as soon as we rely on 1.0.0
-class InvalidArgument(B2Error):
-    """
-    Raised when one or more arguments are invalid
-    """
-
-    def __init__(self, parameter_name, message):
-        """
-        :param parameter_name: name of the function argument
-        :param message: brief explanation of misconfiguration
-        """
-        super().__init__()
-        self.parameter_name = parameter_name
-        self.message = message
-
-    def __str__(self):
-        return f"{self.parameter_name} {self.message}"
-
-
 def main():
     ct = ConsoleTool(b2_api=None, stdout=sys.stdout, stderr=sys.stderr)
     exit_status = ct.run_command(sys.argv)

diff --git a/changelog.d/+remove_redundant_todo.infrastructure.md b/changelog.d/+remove_redundant_todo.infrastructure.md
@@ -0,0 +1 @@
+Remove unused exception class and outdated todo
diff --git a/changelog.d/+skip_draft_step_in_releases.infrastructure.md b/changelog.d/+skip_draft_step_in_releases.infrastructure.md
@@ -0,0 +1 @@
+Skip draft step in releases - all successful releases are public