Fix issue with tab key on Google Sheets

BambooEngine · Nov 7, 2019 · 9e77053 · 9e77053
1 parent 95672dc
commit 9e77053
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 3 deletions.
diff --git a/debian/changelog b/debian/changelog
@@ -1,3 +1,9 @@
+ibus-bamboo (0.6.1-1) stable; urgency=medium
+
+  * New upstream release
+
+ -- Luong Thanh Lam <[email protected]>  Thu, 07 Nov 2019 10:07:52 +0700
+
 ibus-bamboo (0.6.1-0) stable; urgency=medium
 
   * New upstream release

diff --git a/src/ibus-bamboo/engine_backspace.go b/src/ibus-bamboo/engine_backspace.go
@@ -118,7 +118,7 @@ func (e *IBusBambooEngine) keyPressHandler(keyVal, keyCode, state uint32) {
 			macText := e.expandMacro(oldText)
 			e.updatePreviousText(macText, oldText)
 		} else {
-			e.commitText("\t")
+			e.ForwardKeyEvent(keyVal, keyCode, state)
 		}
 		e.preeditor.Reset()
 		return

diff --git a/src/ibus-bamboo/engine_preedit.go b/src/ibus-bamboo/engine_preedit.go
@@ -57,7 +57,8 @@ func (e *IBusBambooEngine) preeditProcessKeyEvent(keyVal uint32, keyCode uint32,
 			macText := e.expandMacro(text)
 			e.commitPreedit(macText)
 		} else {
-			e.commitPreedit(e.getComposedString() + "\t")
+			e.commitPreedit(e.getComposedString())
+			return false, nil
 		}
 		return true, nil
 	}

diff --git a/src/ibus-bamboo/engine_utils.go b/src/ibus-bamboo/engine_utils.go
@@ -319,7 +319,10 @@ func (e *IBusBambooEngine) isValidState(state uint32) bool {
 }
 
 func (e *IBusBambooEngine) canProcessKey(keyVal uint32) bool {
-	if keyVal == IBUS_Space || keyVal == IBUS_BackSpace || keyVal == IBUS_Tab {
+	if keyVal == IBUS_Space || keyVal == IBUS_BackSpace {
+		return true
+	}
+	if e.config.IBflags&IBmarcoEnabled != 0 && keyVal == IBUS_Tab {
 		return true
 	}
 	return e.preeditor.CanProcessKey(rune(keyVal))