Ajout de la restriction sur les potentiels doublons hors meme departement #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbouhadoun
changed the title
nkokla
approved these changes
Oct 15, 2024
| const existingCog = await getCogFromDistrictID(existingAddresseDistrictID) | ||
| // Departement check | ||
|
|
||
| const sliceLength = getDepartmentSliceLength(districtID) |
There was a problem hiding this comment.
Suggested change
| const sliceLength = getDepartmentSliceLength(districtID) | |
| const sliceLength = getDepartmentSliceLength(existingCog) |
There was a problem hiding this comment.
ou
Suggested change
| const sliceLength = getDepartmentSliceLength(districtID) | |
| const sliceLength = getDepartmentSliceLength(currentCog) |
ce qui permet de le sortir de la boucle
Comment on lines
+111
to
+113
| const sliceLength = getDepartmentSliceLength(districtID) | ||
|
|
||
| if (currentCog.slice(0, sliceLength) !== existingCog.slice(0, sliceLength)) { |
There was a problem hiding this comment.
préférer un getDepartmentCode(cog), peut être plus parlant (faire le slice dedans)
There was a problem hiding this comment.
une fonction semblable existe dans lib/util/cog.cjs getCodeDepartement. Mais on ne veut peut être pas cette dépendance ici.
| @@ -196,6 +198,7 @@ describe('getDeltaReport', () => { | |||
| idsToCreate: [], | |||
| idsToUpdate: [bddAddressMock[0].id], | |||
| idsToDelete: [], | |||
| idsUnauthorized: [] | |||
| }) | |||
| }) | |||
There was a problem hiding this comment.
Serait bien de rajouter un test idsUnauthorized, pour pour ce cas hors departement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.