Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

patch: error 500 /ban/stats if no metrics #518

Closed
wants to merge 1 commit into from
Closed

patch: error 500 /ban/stats if no metrics #518

wants to merge 1 commit into from

Conversation

fufeck
Copy link
Contributor

@fufeck fufeck commented Jan 13, 2025

CONTEXT

Il y a un table metrics dans mongo qui est vide a l'installation.
La route /ban/stats retourne une 500 si la table metrics est vide
Le nouveau front ne charge pas si la route /ban/stats répond une 500

@IGNFBourcier
Copy link
Contributor

IMO Dans ce service le renvoie d'une erreur si pas de donnée a du sens. (aka division par 0).
Si il y a un problème avec le front, voir plutôt que faire si il n'y a pas de données (question qui reste d'actualité, si on renvoie un 200, undefined)

@fufeck fufeck closed this Jan 20, 2025
@fufeck fufeck deleted the fufeck_patch_error-500-if-no-metrics branch January 20, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkokla nkokla Awaiting requested review from nkokla

@antoineludeau antoineludeau Awaiting requested review from antoineludeau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fufeck @IGNFBourcier