Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(artifacts): do not base build on artifacts #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xav-ie
Copy link

@xav-ie xav-ie commented Oct 7, 2024

Hello, thank you for providing this cool repository and alternative to homebrew. I think it is really cool.

I am not sure if this PR should just be accepeted even though it does fix #1 . The code is ugly and bad, but I was able to get these casks working:

[
  # already working, but still work
  brewCasks.bitwarden
  (brewCasks.chromium.overrideAttrs (oldAttrs: {
    src = pkgs.fetchurl {
      url = builtins.head oldAttrs.src.urls;
      hash = "sha256-zZHAB7TozshPfoVRfAllYFl4kXrXAok2KqHPa3gSu/c=";
    };
  }))
  brewCasks.firefox
  brewCasks.protonvpn
  brewCasks.raycast
  brewCasks.slack
  # were not working, but now work
  brewCasks.sage # 👀 
  brewCasks.sf-symbols # 😃 
]

I was facing similar issue installing sf-symbols because I wanted them for my sketchybar setup.

I think I made a lot of mistakes, but it is hard for me to tell without testing and some more things to run against, and my issue is already fixed, so I just want to turn in what I have now for review before I try and fix something that already works in a bad way.

nix flake check fails, but that also fails on main.

The build process should use `url` as the primary source of build
operations and somehow produce `artifacts` from them.
@xav-ie xav-ie marked this pull request as ready for review October 7, 2024 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SageMath does not install
1 participant