Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transit Improvements and Acceptance Criteria Summaries #135

Merged
merged 117 commits into from
Feb 8, 2024

Conversation

AshishKuls
Copy link
Collaborator

What existing problem does the pull request solve and why should we include it?

Bring in the Link21 transit improvements and acceptance criteria summaries, merged together to be established as a new development branch.

What is the testing plan?

This will impact all tests

Demonstrate the code is solid by discussing how results are verified and covered by tests

  • Code for this PR is covered in tests
  • Code passes all existing tests

Code formatting

Code should be PEP8 compliant before merging by running a package like black

  • Code linted

Applicable Issues

Please do not create a Pull Request without creating an issue first.

Closes #125
Closes #96

Issues List

e-lo and others added 30 commits March 16, 2022 09:50
Add feature checklist
Create a GH workflow for when milestones are created.

Add an issue to the milestone which is to run the whole test suite WITH EMME.
Add issue creation for release plan // add issue to run full Emme test
1. Adds test docs build on github actions
2. Combines dependencies for docs and general requirements
3. Pins jinja2 version <3.10 because of deprecation of something that MkDocs uses (and sphinx) - can be considered for removal later.
-Add "chore"
-Update templates to have a progress checklist
add more emoji
Cleaned out __init__.py to avoid inro dependency on import bug
skip tests
skip tests
@AshishKuls
Copy link
Collaborator Author

This integrated version of the package executes both the TM2 model run and the acceptance criteria code for generating the tableau summaries.

There are still some manual steps involved in running the model from beginning to end, which will be addressed in separate issues. Fixes for these steps will be implemented and later incorporated into the development branch.

@AshishKuls AshishKuls merged commit 0d1d1a0 into develop Feb 8, 2024
1 of 2 checks passed
@AshishKuls AshishKuls deleted the acceptance-criteria-integration branch February 12, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants