Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Javascript select2 integration #5

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

safaksaylam
Copy link

Simple Javascript select2 integration

@garak
Copy link
Member

garak commented Apr 14, 2017

What's the rationale of this PR?

@safaksaylam
Copy link
Author

Controller, Form Type is not necessary for Select2 integration. I use to EasyAdminBundle. Small Cookbook is not working. Because Form Type RouterInterface is not permission by EasyAdminBundle. I don't know why. I thought it was a simple solution and it would help for beginners.

@garak
Copy link
Member

garak commented Apr 15, 2017

Ok, what I understand here is that you're proposing an alternate approach for ajax cookbook, but the way you're proposing it is not good. You can't just duplicate a page, change something inside and link it with a non-sense title (what's the meaning of "simple Javascript"?)

@safaksaylam
Copy link
Author

That's true. I did the update. Cookbook alternate created in javascript.md.

@garak
Copy link
Member

garak commented Apr 17, 2017

Still, alternate version does not offer any rationale. Why user should use alternate version?

@garak
Copy link
Member

garak commented Oct 5, 2018

Any news on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants