Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Round extension and enemy spawning tweaks #2572

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

Bokkiewokkie
Copy link
Contributor

@Bokkiewokkie Bokkiewokkie commented Oct 29, 2023

About The Pull Request

When the round extension mission is given, it will now check if Rubicon is already cleared and assign Dolos as the objective instead. I've also raised the requirement for these missions to 10, since four players will usually have a harder time getting a successful Rubicon mission.
On top of this I've automatically made the clear system objective unhide the target system, made enemy fleet spawning only happen in sector 2 (So no more empty starmaps because all of the ships spawned in the Syndicate sector) and adjusted the way briefings are generated to make it clear which paper is the extension objective and to maintain more consistency between the papers.
Also adds a hide/unhide button to the starsystem manager, and a label for systems that are hidden (see picture for preview)

Why It's Good For The Game

These are quality of life features for admins, and increases the challenge for people who want to keep fighting after a successful mission.

Testing Photographs and Procedure

I don't have a video but I did actually test this
Preview of hidden system on the starsystem manager:
image

Changelog

🆑
add: Added the option to get another ticket objective if Rubicon is already cleared
tweak: Increased Rubicon objective player requirement to 10
tweak: Mission briefing names will now be consistent in a round
balance: Fleets will now be stronger after the main mission is done
admin: Added button to hide/unhide a system on the starsystem manager
admin: Automatically unhides systems selected for the "clear system" objective
/:cl:

@DeltaFire15
Copy link
Contributor

made enemy fleet spawning only happen in sector 2 (So no more empty starmaps because all of the ships spawned in the Syndicate sector)

All fleets that spawn in sector 3 via faction ticks (aka time) should also already navigate to sector 2 since a long time ago.

@Bokkiewokkie
Copy link
Contributor Author

Bokkiewokkie commented Oct 29, 2023

made enemy fleet spawning only happen in sector 2 (So no more empty starmaps because all of the ships spawned in the Syndicate sector)

All fleets that spawn in sector 3 via faction ticks (aka time) should also already navigate to sector 2 since a long time ago.

This just means they end up piling up in Rubicon, which makes the fight unnecessarily difficult, I've seen a couple of rounds now where a fight in Rubicion was prolonged by multiple new fleets jumping in from sector 3.

@DeltaFire15
Copy link
Contributor

DeltaFire15 commented Oct 29, 2023

This just means they end up piling up in Rubicon, which makes the fight unnecessarily difficult

They navigate to sector 2 individual systems, not rubicon or the sector itself, though they may be there momentarily while passing through. (Rubicon itself is also not a valid destination for said navigation)

@Bokkiewokkie
Copy link
Contributor Author

This just means they end up piling up in Rubicon, which makes the fight unnecessarily difficult

They navigate to sector 2 individual systems, not rubicon or the sector itself, though they may be there momentarily while passing through. (Rubicon itself is also not a valid destination for said navigation)

Alright then, I think spawning them only in sector 2 is just easier regardless though

@DuskLight9978
Copy link
Contributor

This just means they end up piling up in Rubicon, which makes the fight unnecessarily difficult

They navigate to sector 2 individual systems, not Rubicon or the sector itself, though they may be there momentarily while passing through. (Rubicon itself is also not a valid destination for said navigation)

Fleets normally do not travel much in my experience, from feeling they only maneuver based on their assigned 'objective' IE: patrol and defend fleets only moving to friendly syndicate systems; This search for objective points normally only goes out one system out from their current system UNLESS its the Hunt players objective or a go to certain system. Otherwise, if a fleet tasked with taking neutral systems is surrounded by syndicate systems.. It does not move, I am not certain about moving from 3>2 as I don't normally look at sector 3, but I rarely see things leaving Rubicon. This also fits with what I was told in voice that they have a numerical representation of an objective that needs to be overridden or they do their own thing... if its in the one jump distance range.

It may be that Skynet borked, but that has been the experience.

@DeltaFire15
Copy link
Contributor

DeltaFire15 commented Oct 29, 2023

or a go to certain system

Which is exactly what that does. The entirity of non-random fleet navigation is my code. It hooks into that maybe a dozen lines after the line modified in this PR in faction fleet spawning (aka l. 107+ in factions.dm)

@DuskLight9978
Copy link
Contributor

or a go to certain system

Which is exactly what that does. The entirity of non-random fleet navigation is my code. It hooks into that maybe a dozen lines after the line modified in this PR in faction fleet spawning (aka l. 107+ in factions.dm)

I only see specific fleets have a 'go to system' in their variable, the rest do not activate it from the last time I messed with it, Such as the solbuster fleet, could it be their not setting their go to system properly?

Since Dolos doesn't always have a fleet it won't be a specific objective
@Bokkiewokkie Bokkiewokkie merged commit 2a1f8b5 into BeeStation:master Jan 12, 2024
9 checks passed
@Bokkiewokkie Bokkiewokkie deleted the Backtorubicon branch February 11, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants