Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration: add "Global profile configuration" #155

Merged
merged 3 commits into from
Nov 8, 2024

Conversation

jdeniau
Copy link
Contributor

@jdeniau jdeniau commented Nov 4, 2024

Add documentation for Behat/Behat#1501 and Behat/Behat#1513

Copy link
Contributor

@acoulton acoulton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of tiny wording suggestions, otherwise this looks good and ready to merge once the feature PRs merge.

user_guide/configuration.rst Outdated Show resolved Hide resolved
user_guide/configuration.rst Outdated Show resolved Hide resolved
@jdeniau
Copy link
Contributor Author

jdeniau commented Nov 5, 2024

I convert this to "draft" until Behat/Behat#1516 (comment) is resolved.

@jdeniau
Copy link
Contributor Author

jdeniau commented Nov 8, 2024

I convert this to "draft" until Behat/Behat#1516 (comment) is resolved.

Mark as ready now that 3.16 is out.

Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change needed


You can force `--stop-on-failure` and `--strict` via CLI options to override configuration values.


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should remove this extra blank line

Copy link
Contributor

@carlos-granados carlos-granados left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @jdeniau

@acoulton
Copy link
Contributor

acoulton commented Nov 8, 2024

Great, thanks @jdeniau !

@acoulton acoulton merged commit 61ee693 into Behat:v3.0 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants