This repository was archived by the owner on Apr 20, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR is an exemple of what I would like to add in this project.
But first of all, I want to discuss on it with you.
The idea is to use https://github.com/coduo/php-matcher with the
JsonContext
(and maybe others).Sometime, you cannot predict some values of a response. Things like,
uuid
,date
...The idea is to do something like this:
I see two differents way of doing it:
assertSame
andassertEquals
methods of theAsserter
.Devs don't need to update there tests and can directly use it.
But we lost the meaning of the two methods of the Asserter.
The JSON should match: :pystring
andThe JSON node should match :expression
, ...Devs need to update there tests to use it.
We keep the assertSame and assertEquals.
What do you think of it @sanpii ?