Implement Strided RMA #182
Open
+522
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These just perform remote address translation and then call the `*_indirect` variants, as donw with contiguous RMA. Add some comments to improve readability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements
prif_{get,put}_strided{,_indirect}.Notify variants remain unimplemented (as with contiguous RMA) until we implement
prif_notify_type.GASNet does all the heavy lifting for the actual data communication, and the metadata hookup was relatively straightforward.
The only tedious part was manually writing tests in PRIF to invoke each flavor of non-contiguous RMA.