Skip to content

Commit

Permalink
fix: fixing BusStop error and adding all objects test
Browse files Browse the repository at this point in the history
  • Loading branch information
Armando Banuelos authored and Armando Banuelos committed Apr 3, 2024
1 parent 4a67237 commit 9ff068c
Show file tree
Hide file tree
Showing 4 changed files with 69 additions and 44 deletions.
2 changes: 1 addition & 1 deletion src/scenic/simulators/carla/model.scenic
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@ class Chair(Prop):


class BusStop(Prop):
blueprint: Uniform(*blueprints.busStopsModels)
blueprint: Uniform(*blueprints.busStopModels)


class Advertisement(Prop):
Expand Down
58 changes: 29 additions & 29 deletions tests/simulators/carla/all_objects.scenic
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,33 @@ param time_step = 1.0/10
model scenic.simulators.carla.model

ego = new Car
atm = new ATM visible
advertisement = new Advertisement visible
barrel = new Barrel visible
barrier = new Barrier visible
bench = new Bench visible
bicycle = new Bicycle visible
box = new Box visible
#busstop = new BusStop visible
casev = new Case visible
chair = new Chair visible
cone = new Cone visible
container = new Container visible
creasedbox = new CreasedBox visible
debris = new Debris visible
garbage = new Garbage visible
gnome = new Gnome visible
ironplate = new IronPlate visible
kiosk = new Kiosk visible
mailbox = new Mailbox visible
motorcycle = new Motorcycle visible
npccar = new NPCCar visible
pedestrian = new Pedestrian visible
plantpot = new PlantPot visible
table = new Table visible
trafficwarning = new TrafficWarning visible
trash = new Trash visible
truck = new Truck visible
vendingmachine = new VendingMachine visible
atm = new ATM
advertisement = new Advertisement
barrel = new Barrel
barrier = new Barrier
bench = new Bench
bicycle = new Bicycle
box = new Box
busstop = new BusStop
casev = new Case
chair = new Chair
cone = new Cone
container = new Container
creasedbox = new CreasedBox
debris = new Debris
garbage = new Garbage
gnome = new Gnome
ironplate = new IronPlate
kiosk = new Kiosk
mailbox = new Mailbox
motorcycle = new Motorcycle
npccar = new NPCCar
pedestrian = new Pedestrian
plantpot = new PlantPot
table = new Table
trafficwarning = new TrafficWarning
trash = new Trash
truck = new Truck
vendingmachine = new VendingMachine

terminate after 4 seconds
terminate after 1 seconds
9 changes: 0 additions & 9 deletions tests/simulators/carla/atm.scenic

This file was deleted.

44 changes: 39 additions & 5 deletions tests/simulators/carla/test_carla.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,19 +10,53 @@
)


def test_atm_object(loadLocalScenario):
def test_all_objects(loadLocalScenario):
pytest.importorskip("carla")
from scenic.simulators.carla import CarlaSimulator

Check warning on line 15 in tests/simulators/carla/test_carla.py

View check run for this annotation

Codecov / codecov/patch

tests/simulators/carla/test_carla.py#L15

Added line #L15 was not covered by tests

scenario = loadLocalScenario("atm.scenic", mode2D=True)
scenario = loadLocalScenario("all_objects.scenic", mode2D=True)
scene, _ = scenario.generate(maxIterations=10000)
simulator = CarlaSimulator(

Check warning on line 19 in tests/simulators/carla/test_carla.py

View check run for this annotation

Codecov / codecov/patch

tests/simulators/carla/test_carla.py#L17-L19

Added lines #L17 - L19 were not covered by tests
carla_map="Town05", map_path="../../../assets/maps/CARLA/Town05.xodr"
)
simulation = simulator.simulate(scene)
object_class_type = str(type(simulation.objects[1]))
atm_class_type = re.search(r"\.([A-Za-z]+)\'>", object_class_type).group(1)
assert atm_class_type == "ATM"
objects = simulation.objects
expected_objects = [

Check warning on line 24 in tests/simulators/carla/test_carla.py

View check run for this annotation

Codecov / codecov/patch

tests/simulators/carla/test_carla.py#L22-L24

Added lines #L22 - L24 were not covered by tests
"ATM",
"Advertisement",
"Barrel",
"Barrier",
"Bench",
"Bicycle",
"Box",
"BusStop",
"Car",
"Case",
"Chair",
"Cone",
"Container",
"CreasedBox",
"Debris",
"Garbage",
"Gnome",
"IronPlate",
"Kiosk",
"Mailbox",
"Motorcycle",
"NPCCar",
"Pedestrian",
"PlantPot",
"Table",
"TrafficWarning",
"Trash",
"Truck",
"VendingMachine",
]
assert len(objects) == len(expected_objects)
for i in range(len(expected_objects)):
object = str(type(objects[i]))
object_class = re.search(r"\.([A-Za-z]+)\'>", object).group(1)
assert object_class in expected_objects

Check warning on line 59 in tests/simulators/carla/test_carla.py

View check run for this annotation

Codecov / codecov/patch

tests/simulators/carla/test_carla.py#L55-L59

Added lines #L55 - L59 were not covered by tests


def test_throttle(loadLocalScenario):
Expand Down

0 comments on commit 9ff068c

Please sign in to comment.