Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adding seed under reproduce in bug report #225

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

abanuelo
Copy link
Contributor

Description

As part of the bug report template, adding clarification of running scenic commands with a SEED to ensure reproducibility.

Issue Link

Adhoc request from @Eric-Vin

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from Eric-Vin and dfremont March 25, 2024 23:51
Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.94%. Comparing base (d5a21fc) to head (b9810fb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #225      +/-   ##
==========================================
+ Coverage   85.89%   85.94%   +0.05%     
==========================================
  Files         144      144              
  Lines       24767    24767              
==========================================
+ Hits        21274    21287      +13     
+ Misses       3493     3480      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Eric-Vin Eric-Vin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dfremont Thoughts on wording?

@abanuelo abanuelo requested a review from Eric-Vin April 1, 2024 16:16
@abanuelo abanuelo merged commit 1e84dbc into main Apr 2, 2024
26 checks passed
@abanuelo abanuelo deleted the abanuelo/add-seed-to-bug-report-template branch April 24, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants