Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable dynamic scenario termination from closing display #249

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

abanuelo
Copy link
Contributor

Description

Feature that allows users to manually close out a dynamic scenario by closing out the display via the UI and continue subsequent simulations to continue. Here is a video illustrating the working changes

pygame_fixed.mov

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from dfremont and Eric-Vin April 25, 2024 20:02
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.33%. Comparing base (a6e48a2) to head (dcb3111).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/scenic/simulators/newtonian/simulator.py 60.00% 2 Missing ⚠️
src/scenic/core/simulators.py 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #249      +/-   ##
==========================================
- Coverage   91.35%   91.33%   -0.02%     
==========================================
  Files          54       54              
  Lines       13568    13577       +9     
==========================================
+ Hits        12395    12401       +6     
- Misses       1173     1176       +3     
Files with missing lines Coverage Δ
src/scenic/core/simulators.py 96.25% <75.00%> (-0.25%) ⬇️
src/scenic/simulators/newtonian/simulator.py 89.30% <60.00%> (-0.70%) ⬇️

... and 5 files with indirect coverage changes

Copy link
Collaborator

@Eric-Vin Eric-Vin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, and it works great, thanks Armando!

Copy link
Collaborator

@lola831 lola831 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works.

@lola831 lola831 merged commit 26d9da7 into main Dec 17, 2024
4 of 24 checks passed
@lola831 lola831 deleted the abanuelo/feat-ending-dynamic-scenarios branch December 18, 2024 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants