Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: gif cleanup for pytests #285

Merged
merged 6 commits into from
Jul 5, 2024
Merged

chore: gif cleanup for pytests #285

merged 6 commits into from
Jul 5, 2024

Conversation

abanuelo
Copy link
Contributor

Description

After the simulation.gif has been generated by running the test_newtonian.py file, we should delete this file. Also we should ignore simulation.gif for git version control!

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested a review from Eric-Vin June 26, 2024 20:09
Copy link

codecov bot commented Jun 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.30%. Comparing base (d7679fb) to head (1d14751).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #285      +/-   ##
==========================================
- Coverage   91.32%   91.30%   -0.02%     
==========================================
  Files          54       54              
  Lines       13515    13520       +5     
==========================================
+ Hits        12343    12345       +2     
- Misses       1172     1175       +3     

see 4 files with indirect coverage changes

@abanuelo abanuelo merged commit 846b44d into main Jul 5, 2024
26 checks passed
@Eric-Vin Eric-Vin deleted the abanuelo/gif-cleanup branch July 5, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants