alwaysProvidesOrientation Patch and Test

[Eric-Vin]

Description

Fix for alwaysProvidesOrientation

Issue Link

#294

Checklist

• I have tested the changes locally via pytest and/or other means
• I have added or updated relevant documentation
• I have autoformatted the code with black and isort
• I have added test cases (if applicable)

Additional Notes

N/A

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.40%. Comparing base (5f134ad) to head (2a99767).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #300      +/-   ##
==========================================
+ Coverage   91.36%   91.40%   +0.04%     
==========================================
  Files          54       54              
  Lines       13537    13542       +5     
==========================================
+ Hits        12368    12378      +10     
+ Misses       1169     1164       -5     

Files	Coverage Δ
src/scenic/syntax/veneer.py	91.48% <100.00%> (+0.15%)	⬆️

... and 5 files with indirect coverage changes

[dfremont]

Looks good for now -- let's still plan to remove the sampling heuristic entirely.

[amolenaar]

@dfremont @Eric-Vin Thanks for the workaround. I can achieve the same by throwing a RejectionException from the external parameter if no sampler is present.

Does this have effects down the line, if it cannot determine if the sample has an orientation (that's why it does the sampling IIRC)?