Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added No Render Option and Fixed Internal Visualizer Colors #302

Merged
merged 1 commit into from
Aug 25, 2024

Conversation

Eric-Vin
Copy link
Collaborator

Description

Added No Render Option and Fixed Internal Visualizer Colors

Issue Link

N/A

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

N/A

@Eric-Vin Eric-Vin requested a review from dfremont August 22, 2024 22:13
Copy link

codecov bot commented Aug 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.32%. Comparing base (5f134ad) to head (eaf4e3a).
Report is 4 commits behind head on main.

Files Patch % Lines
src/scenic/core/object_types.py 0.00% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #302      +/-   ##
==========================================
- Coverage   91.36%   91.32%   -0.04%     
==========================================
  Files          54       54              
  Lines       13537    13544       +7     
==========================================
+ Hits        12368    12369       +1     
- Misses       1169     1175       +6     
Files Coverage Δ
src/scenic/core/object_types.py 92.85% <0.00%> (-0.26%) ⬇️

... and 6 files with indirect coverage changes

@dfremont dfremont merged commit 0abbbcd into main Aug 25, 2024
19 of 26 checks passed
@dfremont dfremont deleted the NoRenderOption branch August 25, 2024 21:09
@Eric-Vin Eric-Vin requested a review from dfremont August 25, 2024 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants