Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated with world info generation directly from unreal engine #305

Merged
merged 214 commits into from
Oct 8, 2024

Conversation

sunyesta
Copy link

No description provided.

Eric-Vin and others added 13 commits July 29, 2024 13:25
* Minor tweaks to PolygonalRegion.

* Fixed PolygonalRegion points normalization

* Deprecated PolygonalRegion points method.

* Added deprecation test for points.

* Minor tweaks.

* Clarified deprecationTest wrapper message and param.
* AABB Tweaks + Testing

* Added missing AABB update in workspaces.py.
* Added deep boolean operator tests.

* Moved requirement atomic checks to separate transformer.
* 'alwaysProvidesOrientation Patch and Test

* Modified warning message.
@sunyesta sunyesta changed the title Updated with world info generation from unity Updated with world info generation from unreal engine Sep 22, 2024
@sunyesta sunyesta changed the title Updated with world info generation from unreal engine Updated with world info generation directly from unreal engine Sep 22, 2024
Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall! I just left a few minor comments to fix for now, then we can merge it and I can do a more detailed review on the PR to merge airsim into main.

Copy link
Collaborator

@dfremont dfremont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks Mary! The isort check is still failing but I'll just merge this and try to fix it myself.

@dfremont dfremont merged commit 524b391 into BerkeleyLearnVerify:airsim Oct 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants