Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp: migrate leases to be scope scoped instead of global #1304

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

give highest priority to clientIP address

412313a
Select commit
Loading
Failed to load commit list.
Open

dhcp: migrate leases to be scope scoped instead of global #1304

give highest priority to clientIP address
412313a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 25, 2024 in 1s

60.36% (-0.80%) compared to 0a66b6d

View this Pull Request on Codecov

60.36% (-0.80%) compared to 0a66b6d

Details

Codecov Report

Attention: Patch coverage is 48.11321% with 165 lines in your changes missing coverage. Please review.

Project coverage is 60.36%. Comparing base (0a66b6d) to head (412313a).

❌ We are unable to process any of the uploaded JUnit XML files. Please ensure your files are in the right format.

Files with missing lines Patch % Lines
pkg/roles/dhcp/role_migrations.go 0.00% 92 Missing ⚠️
pkg/roles/dhcp/api_leases.go 16.66% 34 Missing and 1 partial ⚠️
pkg/roles/dhcp/scopes.go 72.41% 12 Missing and 4 partials ⚠️
pkg/roles/dhcp/scopes_watch.go 53.33% 5 Missing and 2 partials ⚠️
pkg/roles/dhcp/scope_selector.go 86.48% 4 Missing and 1 partial ⚠️
pkg/extconfig/log.go 0.00% 2 Missing and 1 partial ⚠️
pkg/instance/api_instance.go 83.33% 2 Missing and 1 partial ⚠️
pkg/roles/dhcp/api_scopes.go 81.25% 2 Missing and 1 partial ⚠️
cmd/cli/cli_health.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
- Coverage   61.15%   60.36%   -0.80%     
==========================================
  Files         108      109       +1     
  Lines        6125     6221      +96     
==========================================
+ Hits         3746     3755       +9     
- Misses       2030     2116      +86     
- Partials      349      350       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov