Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dhcp: global options #1462

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

dhcp: global options #1462

wants to merge 3 commits into from

Conversation

BeryJu
Copy link
Owner

@BeryJu BeryJu commented Jan 23, 2025

No description provided.

Copy link

netlify bot commented Jan 23, 2025

Deploy Preview for beryju-gravity canceled.

Name Link
🔨 Latest commit dc8c48c
🔍 Latest deploy log https://app.netlify.com/sites/beryju-gravity/deploys/6791b3835abdf500082f1972

Copy link

codecov bot commented Jan 23, 2025

Bundle Report

Changes will increase total bundle size by 194 bytes (0.01%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gravity-ui-esm 3.71MB 194 bytes (0.01%) ⬆️

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 44.51411% with 177 lines in your changes missing coverage. Please review.

Project coverage is 59.91%. Comparing base (dcae398) to head (dc8c48c).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...kg/roles/dhcp/options/types/role_dhcp_option.pb.go 21.05% 73 Missing and 2 partials ⚠️
...cp/options/types/role_dhcp_option_definition.pb.go 29.00% 69 Missing and 2 partials ⚠️
pkg/roles/dhcp/options/option.go 19.23% 21 Missing ⚠️
pkg/storage/watcher/proto.go 30.00% 6 Missing and 1 partial ⚠️
pkg/roles/dhcp/options/bootstrap.go 96.87% 1 Missing and 1 partial ⚠️
pkg/roles/dhcp/api_scopes.go 0.00% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (dcae398) and HEAD (dc8c48c). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (dcae398) HEAD (dc8c48c)
e2e 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1462       +/-   ##
===========================================
- Coverage   71.01%   59.91%   -11.10%     
===========================================
  Files         125      128        +3     
  Lines        7793     8083      +290     
===========================================
- Hits         5534     4843      -691     
- Misses       1765     2787     +1022     
+ Partials      494      453       -41     
Flag Coverage Δ
e2e ?
unittest 59.91% <44.51%> (-0.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant