Skip to content

Commit

Permalink
GTK4: Convert Geeqie to a GtkApplication
Browse files Browse the repository at this point in the history
GTK4 migration

The following options are deleted:
--fullscreen-start, --fullscreen-stop: Use --fullscreen which is a
toggle
--slideshow-start, --slideshow-stop: Use --slideshow which is a toggle
--tools-show, --tools-hide: Use --tools which is a toggle
--remote: No longer needed
--disable-clutter: Start with GQ_DISABLE_CLUTTER=y[es] geeqie
--cache-maintenance: Start with GQ_CACHE_MAINTENANCE=y[es] geeqie
(disabled in this version)
--new-instance: Start with GQ_NEW_INSTANCE=y[es] geeqie
--blank, --list-add, --list-clear: I do not see the need for them

GQ_CACHE_MAINTENANCE=y geeqie is disabled. It will be fixed in a future
commit.
  • Loading branch information
caclark committed Oct 14, 2024
1 parent 4709e02 commit 0ec522a
Show file tree
Hide file tree
Showing 29 changed files with 2,497 additions and 3,153 deletions.
11 changes: 2 additions & 9 deletions auto-complete/geeqie
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,7 @@ file_types='@(3fr|ani|arw|avif|bmp|cr2|cr3|crw|cur|dds|djvu|dng|erf|gif|gqv|heic

actions='About AddMark0 AddMark1 AddMark2 AddMark3 AddMark4 AddMark5 AddMark6 AddMark7 AddMark8 AddMark9 AlterNone Animate Back ClearMarks CloseWindow ColorProfile0 ColorProfile1 ColorProfile2 ColorProfile3 ColorProfile4 ColorProfile5 ConnectZoom100 ConnectZoom200 ConnectZoom25 ConnectZoom300 ConnectZoom33 ConnectZoom400 ConnectZoom50 ConnectZoomFillHor ConnectZoomFillVert ConnectZoomFit ConnectZoomIn ConnectZoomOut Copy CopyImage CopyPath CopyPathUnquoted CropFourThree CropNone CropOneOne CropRectangle CropSixteenNine CropThreeTwo CutPath Delete DeleteWindow DrawRectangle Escape ExifRotate ExifWin FilterMark0 FilterMark1 FilterMark2 FilterMark3 FilterMark4 FilterMark5 FilterMark6 FilterMark7 FilterMark8 FilterMark9 FindDupes FirstImage FirstPage Flip FloatTools FolderTree Forward FullScreen Grayscale HelpChangeLog HelpContents HelpKbd HelpNotes HelpPdf HelpSearch HelpShortcuts HideBars HideSelectableToolbars HideTools HistogramChanB HistogramChanCycle HistogramChanG HistogramChanR HistogramChanRGB HistogramChanV HistogramModeCycle HistogramModeLin HistogramModeLog Home IgnoreAlpha ImageBack ImageForward ImageHistogram ImageOverlay ImageOverlayCycle IntMark0 IntMark1 IntMark2 IntMark3 IntMark4 IntMark5 IntMark6 IntMark7 IntMark8 IntMark9 KeywordAutocomplete LastImage LastPage LayoutConfig LogWindow Maintenance Mark0 Mark1 Mark2 Mark3 Mark4 Mark5 Mark6 Mark7 Mark8 Mark9 Mirror Move NewCollection NewFolder NewWindow NewWindowDefault NewWindowFromCurrent NextImage NextPage OpenArchive OpenCollection OpenRecent OpenWith OverUnderExposed PanView PermanentDelete Plugins Preferences PrevImage PrevPage Print Quit Rating0 Rating1 Rating2 Rating3 Rating4 Rating5 RatingM1 RectangularSelection Refresh Rename RenameWindow ResetMark0 ResetMark1 ResetMark2 ResetMark3 ResetMark4 ResetMark5 ResetMark6 ResetMark7 ResetMark8 ResetMark9 Rotate180 RotateCCW RotateCW SBar SBarSort SaveMetadata Search SearchAndRunCommand SelectAll SelectInvert SelectMark0 SelectMark1 SelectMark2 SelectMark3 SelectMark4 SelectMark5 SelectMark6 SelectMark7 SelectMark8 SelectMark9 SelectNone SetMark0 SetMark1 SetMark2 SetMark3 SetMark4 SetMark5 SetMark6 SetMark7 SetMark8 SetMark9 ShowFileFilter ShowInfoPixel ShowMarks SlideShow SlideShowFaster SlideShowPause SlideShowSlower SplitDownPane SplitHorizontal SplitNextPane SplitPaneSync SplitPreviousPane SplitQuad SplitSingle SplitTriple SplitUpPane SplitVertical StereoAuto StereoCross StereoCycle StereoOff StereoSBS Thumbnails ToggleMark0 ToggleMark1 ToggleMark2 ToggleMark3 ToggleMark4 ToggleMark5 ToggleMark6 ToggleMark7 ToggleMark8 ToggleMark9 UnselMark0 UnselMark1 UnselMark2 UnselMark3 UnselMark4 UnselMark5 UnselMark6 UnselMark7 UnselMark8 UnselMark9 Up UseColorProfiles UseImageProfile ViewIcons ViewInNewWindow ViewList WriteRotation WriteRotationKeepDate Zoom100 Zoom200 Zoom25 Zoom300 Zoom33 Zoom400 Zoom50 ZoomFillHor ZoomFillVert ZoomFit ZoomIn ZoomOut ZoomToRectangle'

options_basic='--blank --cache-maintenance= --disable-clutter --fullscreen --geometry= --help --list --new-instance --log-file= --remote --slideshow --with-tools --without-tools --version --show-log-window --debug= --grep='

options_remote='--action= --action-list --back --close-window --config-load= --cache-metadata --cache-render= --cache-render-recurse= --cache-render-shared= --cache-render-shared-recurse= --cache-shared= --cache-thumbs= --delay= --first --fullscreen --file= --File= --fullscreen-start --fullscreen-stop --geometry= --get-collection= --get-collection-list --get-destination= --get-file-info --get-filelist= --get-filelist-recurse= --get-rectangle --get-render-intent --get-selection --get-sidecars= --get-window-list --id= --last --list-add= --list-clear --lua= --new-window --next --pixel-info --print0 --PWD= --quit --raise --selection-add= --selection-clear --selection-remove= --slideshow --slideshow-recurse= --slideshow-start --slideshow-stop --tell --tools-hide --tools-show --view='
options='--action= --action-list --back --cache-metadata --cache-render= --cache-render-recurse= --cache-render-shared= --cache-render-shared-recurse= --cache-shared= --cache-thumbs= --close-window --config-load= --debug= --delay= --file= --File= --first --fullscreen --geometry= --get-collection= --get-collection-list --get-destination= --get-file-info --get-filelist= --get-filelist-recurse= --get-rectangle --get-render-intent --get-selection --get-sidecars= --get-window-list --grep= --id= --last --log-file= --lua= --new-window --next --pixel-info --print0 --quit --raise --selection-add= --selection-clear --selection-remove= --show-log-window --slideshow --slideshow-recurse= --tell --tools --view= --version'

_geeqie()
{
Expand Down Expand Up @@ -53,12 +51,7 @@ _geeqie()

if [[ $cur == -* ]]
then
if [[ $COMP_LINE == *"--remote "* ]]
then
COMPREPLY=($(compgen -W '$options_remote' -- "$cur"))
else
COMPREPLY=($(compgen -W '$options_basic' -- "$cur"))
fi
COMPREPLY=($(compgen -W '$options' -- "$cur"))

[[ ${COMPREPLY-} == *[=] ]] && compopt -o nospace
return
Expand Down
71 changes: 71 additions & 0 deletions auto-complete/geeqie-cache-maintenance
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
# bash completion for geeqie-cache-maintenance -*- shell-script -*-

file_types='@(3fr|ani|arw|avif|bmp|cr2|cr3|crw|cur|dds|djvu|dng|erf|gif|gqv|heic|heif|ico|jp2|jpe|jpeg|jpg|jps|jxl|kdc|mef|mos|mpo|mrw|nef|orf|pbm|pdf|pef|pgm|png|pnm|ppm|psd|qif|qtif|raf|raw|rw2|scr|sr2|srf|svg|svgz|tga|tif|tiff|webp|xbm|xpm)'

actions='About AddMark0 AddMark1 AddMark2 AddMark3 AddMark4 AddMark5 AddMark6 AddMark7 AddMark8 AddMark9 AlterNone Animate Back ClearMarks CloseWindow ColorProfile0 ColorProfile1 ColorProfile2 ColorProfile3 ColorProfile4 ColorProfile5 ConnectZoom100 ConnectZoom200 ConnectZoom25 ConnectZoom300 ConnectZoom33 ConnectZoom400 ConnectZoom50 ConnectZoomFillHor ConnectZoomFillVert ConnectZoomFit ConnectZoomIn ConnectZoomOut Copy CopyImage CopyPath CopyPathUnquoted CropFourThree CropNone CropOneOne CropRectangle CropSixteenNine CropThreeTwo CutPath Delete DeleteWindow DrawRectangle Escape ExifRotate ExifWin FilterMark0 FilterMark1 FilterMark2 FilterMark3 FilterMark4 FilterMark5 FilterMark6 FilterMark7 FilterMark8 FilterMark9 FindDupes FirstImage FirstPage Flip FloatTools FolderTree Forward FullScreen Grayscale HelpChangeLog HelpContents HelpKbd HelpNotes HelpSearch HelpShortcuts HideBars HideSelectableToolbars HideTools HistogramChanB HistogramChanCycle HistogramChanG HistogramChanR HistogramChanRGB HistogramChanV HistogramModeCycle HistogramModeLin HistogramModeLog Home IgnoreAlpha ImageBack ImageForward ImageHistogram ImageOverlay ImageOverlayCycle IntMark0 IntMark1 IntMark2 IntMark3 IntMark4 IntMark5 IntMark6 IntMark7 IntMark8 IntMark9 KeywordAutocomplete LastImage LastPage LayoutConfig LogWindow Maintenance Mark0 Mark1 Mark2 Mark3 Mark4 Mark5 Mark6 Mark7 Mark8 Mark9 Mirror Move NewCollection NewFolder NewWindow NewWindowDefault NewWindowFromCurrent NextImage NextPage OpenArchive OpenCollection OpenRecent OpenWith OverUnderExposed PanView PermanentDelete Plugins Preferences PrevImage PrevPage Print Quit Rating0 Rating1 Rating2 Rating3 Rating4 Rating5 RatingM1 RectangularSelection Refresh Rename RenameWindow ResetMark0 ResetMark1 ResetMark2 ResetMark3 ResetMark4 ResetMark5 ResetMark6 ResetMark7 ResetMark8 ResetMark9 Rotate180 RotateCCW RotateCW SBar SBarSort SaveMetadata Search SearchAndRunCommand SelectAll SelectInvert SelectMark0 SelectMark1 SelectMark2 SelectMark3 SelectMark4 SelectMark5 SelectMark6 SelectMark7 SelectMark8 SelectMark9 SelectNone SetMark0 SetMark1 SetMark2 SetMark3 SetMark4 SetMark5 SetMark6 SetMark7 SetMark8 SetMark9 ShowFileFilter ShowInfoPixel ShowMarks SlideShow SlideShowFaster SlideShowPause SlideShowSlower SplitDownPane SplitHorizontal SplitNextPane SplitPaneSync SplitPreviousPane SplitQuad SplitSingle SplitTriple SplitUpPane SplitVertical StereoAuto StereoCross StereoCycle StereoOff StereoSBS Thumbnails ToggleMark0 ToggleMark1 ToggleMark2 ToggleMark3 ToggleMark4 ToggleMark5 ToggleMark6 ToggleMark7 ToggleMark8 ToggleMark9 UnselMark0 UnselMark1 UnselMark2 UnselMark3 UnselMark4 UnselMark5 UnselMark6 UnselMark7 UnselMark8 UnselMark9 Up UseColorProfiles UseImageProfile ViewIcons ViewInNewWindow ViewList WriteRotation WriteRotationKeepDate Zoom100 Zoom200 Zoom25 Zoom300 Zoom33 Zoom400 Zoom50 ZoomFillHor ZoomFillVert ZoomFit ZoomIn ZoomOut ZoomToRectangle'

options_basic='--blank --fullscreen --geometry= --help --help-all --help-gapplication --help-gtk --list --new-instance --log-file= --remote --slideshow --with-tools --without-tools --version --show-log-window --debug= --grep= --action= --action-list --back --close-window --config-load= --cache-metadata --cache-render= --cache-render-recurse= --cache-render-shared= --cache-render-shared-recurse= --cache-shared= --cache-thumbs= --delay= --first --fullscreen --file= --File= --fullscreen-start --fullscreen-stop --geometry= --get-collection= --get-collection-list --get-destination= --get-file-info --get-filelist= --get-filelist-recurse= --get-rectangle --get-render-intent --get-selection --get-sidecars= --get-window-list --id= --last --list-add= --list-clear --lua= --new-window --next --pixel-info --print0 --quit --raise --selection-add= --selection-clear --selection-remove= --slideshow --slideshow-recurse= --tell --tools --view='

options_remote='--action= --action-list --back --cache-metadata --cache-render= --cache-render-recurse= --cache-render-shared= --cache-render-shared-recurse= --cache-shared= --cache-thumbs= --close-window --config-load= --debug= --delay= --file= --File= --first --fullscreen --geometry= --get-collection= --get-collection-list --get-destination= --get-file-info --get-filelist= --get-filelist-recurse= --get-rectangle --get-render-intent --get-selection --get-sidecars= --get-window-list --grep --id= --last --log-file= --lua= --new-window --next --pixel-info --print0 --quit --raise --selection-add= --selection-clear --selection-remove= --show-log-window --slideshow --slideshow-recurse= --tell --tools --view= --version'

_geeqie-cache-maintenance()
{
local cur prev
_init_completion -s || return

case "$prev" in
--action)
COMPREPLY=($(compgen -W '$actions' -- "$cur"))
return
;;

--cache-maintenance | --cache-render | --cache-render-recurse | --cache-render-shared-recurse | --get-filelist | --get-filelist-recurse | --slideshow-recurse)
_filedir
return
;;

--cache-shared | --cache-thumbs)
COMPREPLY=($(compgen -W 'clean clear' -- "$cur"))
return
;;

--config-load)
_filedir xml
return
;;

--file | --File | --get-destination | --get-sidecars | --list-add | --selection-add | --selection-remove | --view)
_filedir $file_types
return
;;

--get-collection)
collection="$(find $HOME/.local/share/geeqie/collections/ -maxdepth 1 -name "*gqv" -exec basename {} \;)"
COMPREPLY=($(compgen -W '$collection' -- "$cur"))
return
;;

--lua)
_filedir lua
return
;;
esac

if [[ $cur == -* ]]
then
if [[ $COMP_LINE == *"MAINTAIN"* ]]
then
COMPREPLY=($(compgen -W '$options_maintenance' -- "$cur"))
else
COMPREPLY=($(compgen -W '$options_basic' -- "$cur"))
fi

[[ ${COMPREPLY-} == *[=] ]] && compopt -o nospace
return
fi

_filedir $file_types

} && complete -F _geeqie-cache-maintenance geeqie-cache-maintenance

# ex: filetype=sh
26 changes: 26 additions & 0 deletions doc/docbook/CommandLineOptions.xml
Original file line number Diff line number Diff line change
Expand Up @@ -474,6 +474,32 @@ can be used to modify this behavior on an individual basis e.g.</para>
</listitem>
</varlistentry>
</variablelist>

<para>All other command line parameters are used as plain files if they exist, or a URL or a folder.
The name of a collection, with or without either path or extension (.gqv) may be used.</para>

<para>If more than one folder is on the command line, only the last will be used.</para>
</refsect2>

<refsect2 id='if_more_than_one_file_is_on_the_command_'><title>If more than one file is on the command line:</title>

<para>If they are in the same folder, that folder will be opened and those files will be selected.
If they are not in the same folder, a new Collection containing those files will be opened.</para>

<para>To run Geeqie as a new instance, use:
GQ_NON_UNIQUE=1 geeqie
Normally a single set of configuration files is used for all instances.
However, the environment variables XDG_CONFIG_HOME, XDG_CACHE_HOME, XDG_DATA_HOME
can be used to modify this behavior on an individual basis e.g.
XDG_CONFIG_HOME=/tmp/a XDG_CACHE_HOME=/tmp/b GQ_NON_UNIQUE=1 geeqie</para>

<para>To disable Clutter use:
GQ_DISABLE_CLUTTER=1 geeqie</para>

<para>To run or stop Geeqie in cache maintenance (non-GUI) mode use:
GQ_CACHE_MAINTENANCE=1 geeqie <emphasis role='strong' remap='B'>--help</emphasis></para>

<para>User manual: https://www.geeqie.org/help/GuideIndex.html</para>
</refsect2>
</refsect1>

Expand Down
14 changes: 12 additions & 2 deletions meson.build
Original file line number Diff line number Diff line change
Expand Up @@ -671,6 +671,14 @@ i18n.merge_file(
install : true,
install_dir : join_paths(datadir, 'applications'))

i18n.merge_file(
input : 'org.geeqie.cache-maintenance.desktop.in',
output : 'org.geeqie.cache-maintenance.desktop',
type : 'desktop',
po_dir : podir,
install : true,
install_dir : join_paths(datadir, 'applications'))

i18n.merge_file(
input : 'org.geeqie.Geeqie.appdata.xml.in',
output : 'org.geeqie.Geeqie.appdata.xml',
Expand All @@ -682,11 +690,12 @@ i18n.merge_file(
configure_file(input: 'geeqie.spec.in', output: 'geeqie.spec', configuration: conf_data)

isolate_test_sh = find_program('isolate-test.sh', dirs : scriptsdir, required : true)
dbus_session_sh = find_program('dbus-session.sh', dirs : scriptsdir, required : true)

# Basic test of the executable
xvfb = find_program('xvfb-run', required : false)
if xvfb.found()
test_cmd = [xvfb.full_path(), '--auto-servernum', geeqie_exe.full_path(), '--version']
test_cmd = [dbus_session_sh.full_path(), xvfb.full_path(), '--auto-servernum', geeqie_exe.full_path(), '--version']
test('Basic test', isolate_test_sh, args: test_cmd, timeout: 100, suite: 'functional')
summary({'xvfb' : ['Test runs:', true]}, section : 'Testing', bool_yn : true)
else
Expand Down Expand Up @@ -716,8 +725,9 @@ if option.enabled()
image_name = path_array[path_array.length() - 1]

should_fail = image_name.startswith('fail')
test_cmd = [image_test_py.full_path(), geeqie_exe.full_path(), image]
test_cmd = [dbus_session_sh.full_path(), image_test_py.full_path(), geeqie_exe.full_path(), image]
test('Image_ ' + image_name, isolate_test_sh, args: test_cmd, should_fail : should_fail, timeout: 100, suite: ['functional', 'image'])

endforeach
summary({'Image tests' : ['Test runs:', true]}, section : 'Testing', bool_yn : true)
else
Expand Down
4 changes: 2 additions & 2 deletions org.geeqie.Geeqie.desktop.in
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,8 @@ Icon=geeqie
Type=Application
Terminal=false
# Startup notification disabled, since the remote -r switch may not open a new window...
#StartupNotify=false
#StartupWMClass=geeqie
StartupNotify=true
StartupWMClass=geeqie
NotShowIn=X-Geeqie;
Categories=Graphics;Viewer;
MimeType=application/x-navi-animation;image/bmp;image/x-bmp;image/x-MS-bmp;image/gif;image/x-icon;image/jpeg;image/png;image/x-portable-anymap;image/x-portable-bitmap;image/x-portable-graymap;image/x-portable-pixmap;image/x-tga;image/tiff;image/x-xbitmap;image/x-xpixmap;image/svg;image/svg+xml;image/x-png;image/xpm;image/x-ico;
Expand Down
14 changes: 14 additions & 0 deletions org.geeqie.cache-maintenance.desktop.in
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
[Desktop Entry]
Name=Geeqie Cache Maintenance
GenericName=Image Viewer
Comment=View and manage images
Exec=/bin/true
Icon=geeqie
Type=Application
Terminal=false
StartupNotify=true
StartupWMClass=geeqie
NotShowIn=X-Geeqie;
Categories=Graphics;Viewer;
MimeType=application/x-navi-animation;image/bmp;image/x-bmp;image/x-MS-bmp;image/gif;image/x-icon;image/jpeg;image/png;image/x-portable-anymap;image/x-portable-bitmap;image/x-portable-graymap;image/x-portable-pixmap;image/x-tga;image/tiff;image/x-xbitmap;image/x-xpixmap;image/svg;image/svg+xml;image/x-png;image/xpm;image/x-ico;
Keywords=Picture;Slideshow;Graphics;
38 changes: 38 additions & 0 deletions scripts/dbus-session.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
#!/bin/sh
#**********************************************************************
# Copyright (C) 2024 - The Geeqie Team
#
# Author: Colin Clark
#
# This program is free software; you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; either version 2 of the License, or
# (at your option) any later version.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License along
# with this program; if not, write to the Free Software Foundation, Inc.,
# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
#**********************************************************************

set -e

# This will automatically pass the command name and args in the expected order.
# And `set -e` (above) means that we'll automatically exit with the same return
# code as our sub-command.
# Start with a clean environment containing only these variables.
#
# G_DEBUG="fatal-warnings" will force an abort if a warning or
# critical error is encountered.
# https://docs.gtk.org/glib/running.html#environment-variables

# Inhibit shellcheck warning SC2154 - var is referenced but not assigned
echo "${DBUS_SESSION_BUS_ADDRESS:-}"
echo "${XDG_CONFIG_HOME:-}"
echo "${XDG_RUNTIME_DIR:-}"

env -i DBUS_SESSION_BUS_ADDRESS="$DBUS_SESSION_BUS_ADDRESS" HOME="$HOME" XDG_CONFIG_HOME="$XDG_CONFIG_HOME" XDG_RUNTIME_DIR="$XDG_RUNTIME_DIR" G_DEBUG="fatal-warnings" "$@"
3 changes: 0 additions & 3 deletions scripts/generate-man-page.sh
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@ zooming, panning, thumbnails and sorting images into collections.
Generated for version:
[SEE ALSO]
Full documentation: https://www.geeqie.org/help/GuideIndex.html
[BUGS]
Please send bug reports and feedback to https://github.com/BestImageViewer/geeqie/issues
Expand Down
10 changes: 5 additions & 5 deletions scripts/image-test.py
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ def __str__(self) -> str:

def main(argv) -> int:
geeqie_exe = argv[1]
test_image_path = argv[2]
test_image_path = "--file=" + argv[2]

# All geeqie commands start with this.
geeqie_cmd_prefix = ["xvfb-run", "--auto-servernum", geeqie_exe]
Expand All @@ -93,9 +93,9 @@ def main(argv) -> int:
# try/finally to ensure we clean up geeqie_proc
try:
start_time = time.monotonic()

# Wait up to MAX_GEEQIE_INIT_TIME_S for remote to initialize.
command_fifo_path = pathlib.Path(os.environ["XDG_CONFIG_HOME"], "geeqie/.command")
command_fifo_path = pathlib.Path(os.environ["XDG_CONFIG_HOME"], "geeqie/layouts")

while not command_fifo_path.exists():
time.sleep(1)
if time.monotonic() - start_time > MAX_GEEQIE_INIT_TIME_S:
Expand All @@ -107,7 +107,7 @@ def main(argv) -> int:
raise GeeqieTestError("2-second post-init check", geeqie_proc)

file_info_result = subprocess.run(
args=[*geeqie_cmd_prefix, "--remote", "--get-file-info"],
args=[*geeqie_cmd_prefix, "--get-file-info"],
capture_output=True, text=True, timeout=MAX_REMOTE_CMD_TIME_S)

# Check if Geeqie crashed (which would cause xvfb-run to terminate)
Expand All @@ -116,7 +116,7 @@ def main(argv) -> int:
raise GeeqieTestError("remote command processing", geeqie_proc)

# Request shutdown
subprocess.run(args=[*geeqie_cmd_prefix, "--remote", "--quit"],
subprocess.run(args=[*geeqie_cmd_prefix, "--quit"],
timeout=MAX_REMOTE_CMD_TIME_S)

# If there's a timeout, or the exit code isn't zero, flag it.
Expand Down
Loading

0 comments on commit 0ec522a

Please sign in to comment.