Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add cli-ui gem dependency #23

Merged
merged 1 commit into from
Jun 13, 2024
Merged

Add cli-ui gem dependency #23

merged 1 commit into from
Jun 13, 2024

Conversation

pat-whitrock
Copy link
Contributor

The Developer CLI uses cli-ui, but doesn't include it as a dependency, thus requiring the vendoring app to depend on that gem directly in order to leverage the CLI.

Running bundle exec rails persona:create from a project that doesn't depend on cli-ui currently produces the following error:

NameError: uninitialized constant DemoMode::Clis::MultiWordSearchPatch::CLI (NameError)

      CLI::UI::Prompt.const_get(:InteractiveOptions)
             ^^^^^^^^

smudge
smudge approved these changes Jun 13, 2024
View reviewed changes
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM!

@smudge smudge merged commit 815da3c into Betterment:main Jun 13, 2024
8 checks passed
@pat-whitrock pat-whitrock deleted the pw/cli-ui branch June 13, 2024 15:55
@pat-whitrock pat-whitrock mentioned this pull request Jun 13, 2024
Merged
smudge pushed a commit that referenced this pull request Jun 13, 2024
@pat-whitrock
Add require for cli/ui (#25)
fb63de7 
This is related to #23. I
was too hasty and forgot to actually `require 'cli/ui'` as outlined in
the
[cli-ui](https://github.com/Shopify/cli-ui?tab=readme-ov-file#installation)
installation instructions.

I tested this in a project using demo_mode by pointing it at this branch
of the gem locally and this resolved the same issue mentioned in
#23 (which that PR didn't
resolve on its own).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smudge smudge smudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pat-whitrock @smudge