Generate a login link when running the demo mode CLI #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rzane
commented
Jul 23, 2024
rzane
commented
rzane
commented
Jul 23, 2024
Comment on lines
+49
to
+57
| def session_url(session) | ||
| routes = DemoMode::Engine.routes | ||
|
|
||
| options = routes.default_url_options.presence | ||
| options ||= ActionMailer::Base.default_url_options.presence if defined?(ActionMailer::Base) | ||
| options ||= { only_path: true } | ||
|
|
||
| routes.url_for(controller: 'demo_mode/sessions', action: 'show', id: session, **options) | ||
| end |
There was a problem hiding this comment.
This is a best effort approach. We try to resolve the URL in the following order:
- You can explicitly configure URL generation by setting
DemoMode::Engine.routes.default_url_options. - We'll fallback to the
default_url_optionsyou've used forconfig.action_mailer.default_url_options. This should work well for the majority of applications and custom configuration probably won't be necessary. - We'll fallback to generating just a path.
rzane
commented
Jul 23, 2024
Comment on lines
+4
to
+6
| def email | ||
| '[email protected]' | ||
| end |
There was a problem hiding this comment.
The DemoMode CLI expects the signinable to have an email, but the DummyUser in our test personas doesn't actually have an email attribute.
smudge
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.