Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: 토너먼트이슈 수정 #119

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Refactor: 토너먼트이슈 수정 #119

merged 2 commits into from
Jul 1, 2024

Conversation

Hosung99
Copy link
Member

@Hosung99 Hosung99 commented Jul 1, 2024

#️⃣연관된 이슈

#105

📝작업 내용

한글 닉네임시 중복이벤트 발생하던 것 수정
검색창에 자동 Focus되도록 수정

스크린샷 (선택)

💬리뷰 요구사항(선택)

리뷰어가 특별히 봐주었으면 하는 부분이 있다면 작성해주세요

ex) 메서드 XXX의 이름을 더 잘 짓고 싶은데 혹시 좋은 명칭이 있을까요?

@Hosung99 Hosung99 added the Refactor Extra attention is needed label Jul 1, 2024
@Hosung99 Hosung99 added this to the 6월 5주차 milestone Jul 1, 2024
@Hosung99 Hosung99 requested a review from mixsung July 1, 2024 05:12
@Hosung99 Hosung99 self-assigned this Jul 1, 2024
mixsung
mixsung approved these changes Jul 1, 2024
View reviewed changes
Copy link
Contributor

@mixsung mixsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 한글이 특정 이벤트(keydown)에서 2번 발생하는 것을 알게 되었네요

@mixsung mixsung merged commit 88b24e3 into dev Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixsung mixsung mixsung approved these changes

Assignees

@Hosung99 Hosung99

Labels
Refactor Extra attention is needed
Projects
None yet
Milestone
6월 5주차
Development

Successfully merging this pull request may close these issues.
2 participants
@Hosung99 @mixsung