Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: 회원가입 탈퇴 모달 추가 #127

Merged
merged 5 commits into from
Jul 16, 2024
Merged

Feature: 회원가입 탈퇴 모달 추가 #127

merged 5 commits into from
Jul 16, 2024

Conversation

Hosung99
Copy link
Member

#️⃣연관된 이슈

#125

📝작업 내용

회원가입 탈퇴 시 모달로 선택하는 기능입니다.

스크린샷 (선택)

image

💬리뷰 요구사항(선택)

디자인적으로 맘에 안드시는 부분 있으면 적극 반영하겠습니다!~

@Hosung99 Hosung99 added the Feature New feature or request label Jul 12, 2024
@Hosung99 Hosung99 requested a review from mixsung July 12, 2024 10:00
@Hosung99 Hosung99 self-assigned this Jul 12, 2024
mixsung
mixsung requested changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@mixsung mixsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

버튼이 가운데 있는 느낌이 있어서 아래쪽으로 내려도 좋을 것 같습니다~

@Hosung99
Copy link
Member Author

버튼이 가운데 있는 느낌이 있어서 아래쪽으로 내려도 좋을 것 같습니다~

넵 버튼 조금 내렸습니다!
조금 수정할게 있어서 완료하면 제가 머지할게요

mixsung
mixsung approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@mixsung mixsung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

피드백 반영 감사합니다!

@mixsung mixsung merged commit 2f0befa into dev Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixsung mixsung mixsung approved these changes

Assignees

@Hosung99 Hosung99

Labels
Feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hosung99 @mixsung