Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 회원가입 직후 아바타 변경없이 저장 시 400 에러 수정 #94

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

mixsung
Copy link
Contributor

@mixsung mixsung commented Jun 26, 2024

#️⃣연관된 이슈

#93

📝작업 내용

회원가입 직후, 아바타가 기본으로 되어있는데 이 상태에서 아바타 변경없이 저장 버튼을 누르면 아바타 변경 API에서 400 에러가 발생
아바타 변경 API에 보내는 변경된 아바타 id 변수가 기본 아바타 상태이고 선택되지 않았을 때 기본값이 할당되어 있지않아서 발생한 문제

Screenshot 2024-06-26 at 8 56 55 PM
Screenshot 2024-06-26 at 8 58 07 PM

@mixsung mixsung added the Bug Something isn't working label Jun 26, 2024
@mixsung mixsung added this to the 6월 4주차 milestone Jun 26, 2024
@mixsung mixsung requested a review from Hosung99 June 26, 2024 12:36
@mixsung mixsung self-assigned this Jun 26, 2024
Copy link
Member

@Hosung99 Hosung99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이미지를 선택 안했을 시, 버튼을 비활성화 하는 것이 좋을 것 같습니다.
불필요한 API요청 같습니다!

Copy link
Member

@Hosung99 Hosung99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

API막는 것도 좋은 것 같습니다!
수정하시느라 고생하셨어요~

@Hosung99 Hosung99 merged commit 3f0f579 into dev Jun 27, 2024
@Hosung99 Hosung99 deleted the dev-bug#93 branch June 27, 2024 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants