feature: add macos signing + notarization. #1191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Change secretes management in build
jsarabia
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @danparisd and @PurpleGuitar)
|
@jsarabia You can merge this and make a release at your discretion! |
wkelly17
added a commit
that referenced
this pull request
Nov 8, 2024
… Change secretes management in build (#1191)
jsarabia
added a commit
that referenced
this pull request
Nov 8, 2024
* find error that was with previous build * Fixed bug where verse marker was not added after editing chapter. (#1190) The issue here is that we are checking based on the label and not the formatted label. The label for chapter maker 2 and verse marker 2 is just "2", however, the formatted label is "chapter-marker-2" and "verse-marker-2" * Protect setting recordedVerses (#1192) * Protect setting recordedVerses A crash seems to be connected to a concurrent modification issue Also clean up in undock * Update AudioWorkspaceView.kt * feature: add macos signing + notarization. Upgrade install4j version. Change secretes management in build (#1191) * Update VERSION * finish rebase dev adn debug signing --------- Co-authored-by: Darrell Cole Hill <[email protected]> Co-authored-by: Joe <[email protected]>
wkelly17
added a commit
that referenced
this pull request
Jan 2, 2025
… Change secretes management in build (#1191)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature:
This change is