Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH Get amino acid file for argannot rather than nucleotide file #36

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

Vedanth-Ramji
Copy link
Member

ARG-ANNOT is comprised of coding sequences. The data wasn't being handled properly before as contig mode was used when passing coding sequences to RGI. Now, the amino acid version of ARG-ANNOT is used with protein mode when running the database in RGI.

@luispedro
Copy link
Member

ARG-ANNOT is comprised of coding sequences. The data wasn't being handled properly before as contig mode was used when passing coding sequences to RGI. Now, the amino acid version of ARG-ANNOT is used with protein mode when running the database in RGI.

Please rewrite history to put this info in the commit message and not just in the PR

@Vedanth-Ramji Vedanth-Ramji force-pushed the argannot_protein_update branch from 17f4009 to c20f1e2 Compare April 11, 2024 06:45
- ARG-ANNOT is comprised of coding sequences. The data wasn't being handled properly before as contig mode was used when pass>
- One to many ARO mapping such as NG_047831:101-955 to Erm(K) and almG eliminated as protein mode used
- A total of 10 ARO mappings changed
@Vedanth-Ramji Vedanth-Ramji force-pushed the argannot_protein_update branch from c20f1e2 to 707e2b0 Compare April 12, 2024 00:24
@luispedro luispedro merged commit 76a44fc into main Apr 12, 2024
12 checks passed
@luispedro luispedro deleted the argannot_protein_update branch April 12, 2024 00:27
@luispedro
Copy link
Member

I merged, but then realised that this should have been in the CHANGELOG as well

@Vedanth-Ramji
Copy link
Member Author

I'll add that right now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants