Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD Cut_Off column to argNorm outputs #90

Merged
merged 2 commits into from
Feb 25, 2025

Conversation

Vedanth-Ramji
Copy link
Member

RGI Cut_Off scores for all ARO mappings are now added to argNorm outputs. These Cut_Off scores are stored with ARO mappings in ARO mapping tables. Manually curated genes are assigned 'Manual Curation' as the cut-off score. All other genes use RGI's standard 'Perfect', 'Strict', and 'Loose' cut-offs.

RGI Cut_Off scores for all ARO mappings are now added to argNorm outputs. These Cut_Off scores are stored with ARO mappings in ARO mapping tables. Manually curated genes are assigned 'Manual Curation' as the cut-off score. All other genes use RGI's standard 'Perfect', 'Strict', and 'Loose' cut-offs.
@luispedro
Copy link
Member

Thanks. Two related requests:

  1. The term for manual curation should just be a single word, Manual
  2. The manual curation tables don't need to have it stored explicitly. Just add it in memory after loading

…f in get_aro_mapping_table() rather than storing it in manual curation tables.
@Vedanth-Ramji
Copy link
Member Author

Done! There's still a diff for groot curation. I looked into it, and this is once again the same case of manual curation files initially being saved as CRLF and now changing to LF, so I committed the change

@luispedro luispedro merged commit d1afb3a into BigDataBiology:main Feb 25, 2025
7 checks passed
@Vedanth-Ramji Vedanth-Ramji deleted the add_cutoffs branch February 25, 2025 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants