Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added flush mode to video player to fix black screen on media loop #3015

Closed
wants to merge 1 commit into from
Closed

Conversation

steawth
Copy link

@steawth steawth commented Jul 28, 2023

I was finally able to track down the cause of the black screen appearing on video loop. The solution was found in the comments on the QTBUG-49446 discussion page.
Build tested on linux using the latest master branch.

@Bionus
Copy link
Owner

Bionus commented Jul 28, 2023

I see the change is made only for the Android version, was this bug Android specific?

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #3015 (f01234c) into master (0f774c4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3015   +/-   ##
=======================================
  Coverage   34.12%   34.12%           
=======================================
  Files         346      346           
  Lines       22655    22655           
  Branches      480      480           
=======================================
  Hits         7730     7730           
  Misses      14808    14808           
  Partials      117      117           

@steawth
Copy link
Author

steawth commented Jul 29, 2023

After a rebuild I see that this change did not fix what I thought it had on linux. I will continue looking for a solution to the video going black in the image window for a few ms on loop of the video (problem seems similar to QTBUG-34706 ). This change might help with the issue on android but I do not know how to build grabber for this platform. Feel free to close the pull request if you find that this is not the case.

@Bionus
Copy link
Owner

Bionus commented Aug 1, 2023

If your issue was on Linux, then yes this won't work since the QML files are only used on the mobile version. The desktop player is managed in video-player.cpp.

However, I recently upgraded Qt from 5.15 to 6.5, maybe that could have fixed the issue by itself? (there has been big changes to the multimedia back-ends) Maybe you could try on the nightly version?

@steawth
Copy link
Author

steawth commented Aug 12, 2023

After a quick run of the nightly version on Windows this seems to be the case. I'll go ahead and close this pull request.

@steawth steawth closed this Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants