Fix recursion to exclude self node

BishopFox · Jul 11, 2023 · 853a7ab · 853a7ab
1 parent c17c378
commit 853a7ab
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/client/command/processes/pstree.go b/client/command/processes/pstree.go
@@ -50,9 +50,16 @@ func (n *node) insert(proc *commonpb.Process) {
 }
 
 func (n *node) findParent(proc *commonpb.Process) *node {
+	// Empty node
 	if n.Value == nil {
 		return nil
 	}
+	// Skip self when called from reorder
+	// otherwise things might explode, see #1340
+	if n.Value.Pid == proc.Pid {
+		return nil
+	}
+	// Found parent
 	if n.Value.Pid == proc.Ppid {
 		return n
 	}