(Delegator) Add endpoint to retrieve eoa addr #1497
Conversation
|
Warning Rate Limit Exceeded@nick-bisonai has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 46 minutes and 41 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe recent modifications enhance the security and functionality of the fee payer address retrieval process in the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- delegator/sign/controller.go (1 hunks)
- delegator/sign/route.go (1 hunks)
- delegator/tests/sign_test.go (1 hunks)
Additional comments not posted (3)
delegator/sign/route.go (1)
15-15: LGTM! Ensure thegetFeePayerAddressfunction is thoroughly tested.Verification successful
The test function
TestGetFeePayerAddressindelegator/tests/sign_test.goappears to cover the functionality of thegetFeePayerAddressendpoint comprehensively. It includes setup, making a GET request to the/api/v1/sign/feePayerendpoint, and validating the response. The test also checks for proper initialization and ensures the correct fee payer address is returned.
- The
getFeePayerAddressfunction is implemented indelegator/sign/controller.goand handles errors appropriately.- The test function
TestGetFeePayerAddressverifies the endpoint's functionality, including error handling and response validation.This confirms that the new
/feePayerendpoint is well-integrated and tested.Scripts Executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the integration of the new `/feePayer` endpoint. # Test: Search for the function usage in tests. Expect: Proper test coverage. rg --type go $'TestGetFeePayerAddress'Length of output: 110
Script:
#!/bin/bash # Locate the implementation of the `getFeePayerAddress` function. ast-grep --lang go --pattern 'func getFeePayerAddress($_) $_' # Display the content of the test function `TestGetFeePayerAddress`. rg --type go --context 10 'func TestGetFeePayerAddress' delegator/tests/sign_test.goLength of output: 2080
Script:
#!/bin/bash # Display the complete content of the test function `TestGetFeePayerAddress` to ensure comprehensive coverage. rg --type go --context 20 'func TestGetFeePayerAddress' delegator/tests/sign_test.goLength of output: 1497
delegator/tests/sign_test.go (1)
73-73: LGTM! Ensure the private key comparisons reflect the intended security enhancements.Also applies to: 80-80
delegator/sign/controller.go (1)
104-106: Good handling of hexadecimal prefix in private keys. Ensure consistent handling across all functions that process private keys.
test: fix test err test: fix test err
nick-bisonai
force-pushed
the
feat/delegator-endpoint-for-eoa-addr
branch
from
44df293 to
624e022
Compare
Description
Adds endpoint which returns fee payer public address, to be referenced from orakl-sentry
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment