Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove altcoin Network implementations #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

afk11
Copy link
Member

@afk11 afk11 commented Jan 9, 2019

This PR removes the Network implementations of dash, doge, litecoin, viacoin, and zcash. We added the NetworkInterface early on so people could 'bring their own' implementations when using the project, but in hindsight I don't think we should have accepted extra implementations into the repo.

The motivation for this is there have been a bunch of PR's to change version bytes over the years, but this breaks backwards compatibility, and I don't think this viable since we're trying to be stable now :) Another example is litecoins SCRIPTHASH2 version byte - we can't change the version here without upsetting people who depend on it being the old way.

I think a better way for dealing with networks is something like @dan-da's coinparams project, which implements NetworkInterface and has a massive set of network configurations available.

If you were using these to-be-removed network objects, just copy them (& and the tests!) into your code base.

If you need to write a new network, write a new class extending Network, and fill in the required properties! You can grab these from your coins chainparams.cpp (if it's a new enough fork of bitcoin), or else they'll be scattered around the codebase (if it's a really ancient fork)

…t, written by devs in their own project (private or public), or just use coinparams-bitwasp-addon at a certain version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant