Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BC break: remove BloomFilter related classes to separate package #871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

afk11
Copy link
Member

@afk11 afk11 commented Jan 22, 2021

bitwasp/bitcoin-bloom-filter https://github.com/Bit-Wasp/bitcoin-php-bloom-filter

A dependency required for this doesn't support PHP8 yet, so I'd rather move it out of the core library. I've never heard of anyone actually using this.

BC break due to removal of BloomFilter, PartialMerkleTree, FilteredBlock, related serializers, but also removal of BlockInterface::filter

…wasp/bitcoin-bloom-filter https://github.com/Bit-Wasp/bitcoin-php-bloom-filter). A dependency of this going out of date and we don't really need it AFAICT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant