Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add fastlane for F-Droid #2020

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions metadata/en-US/changelogs/41.txt

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe remove 41.txt unless it's really the "initial release". It's probably not the latest one either, so nobody'll see it anyway, with build.gradle having 45 right now.

Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Initial Release
10 changes: 10 additions & 0 deletions metadata/en-US/full_description.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
Our simple yet powerful app is at the center of the BitBox ecosystem. An all-in-one solution to securely manage your digital assets with ease.

See more details at https://shiftcrypto.ch/app/

A BitBox02 hardware wallet is required.
https://shiftcrypto.ch/bitbox02/

Note: this app will sync around 200mb of blockchain header data. Be careful with using your mobile data.

Please send your feedback to [email protected].
Binary file added metadata/en-US/images/featureGraphic.png
thisconnect marked this conversation as resolved.
Show resolved Hide resolved
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added metadata/en-US/images/icon.png
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

while 48x48 is technically OK (it's the bare minimum size), it might not look that good on higher resolution devices. Is there a larger variant available (up to 512x512 is permitted; 192x192 would be fine and at least 96x96 desirable)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not find it in 512x512 unfortunately. @benma, may you provide me with the icon as 512x512 PNG?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not a deal breaker. As I wrote: 48x48 is the bare (accepted) minimum. If there's a better resolution, yes please. If not: 🤷‍♂️

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Original from Play 😜

Copy link
Collaborator

@thisconnect thisconnect Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it should be round then the one you posted is fine (I think), but this was changed for the desktop app, see 55006ff

and the new desktop icon: https://github.com/digitalbitbox/bitbox-wallet-app/blob/master/frontends/qt/resources/app_icon_source.png

the source of the logo: https://github.com/digitalbitbox/bitbox-wallet-app/blob/master/frontends/android/icon_source.png

let me know if you need anything else.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thisconnect the one I just posted was taken from the app's listing at GooglePlay, so it should be the correct one for fastlane/metadata/android. But of course your choice, it's your app 😉

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benma. I updated the graphic.

Copy link
Collaborator

@thisconnect thisconnect Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Either one looks good to me, but I don't know if it has to be round on Android, but this shouldn't be a blocker I guess, lets see if this works.

we'll still need to look into the size issue of the app #2020 (comment)

Copy link

@IzzySoft IzzySoft Jun 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if it has to be round on Android

AFAIK both are fine. Especially when it comes to Fastlane, which is just to represent the app in "listings". For "Android internals" (e.g. show the icon in the app drawer etc), Fastlane is not used. So IMHO the choice here is up to you. And as pointed out: that round one is what is used by your PlayStore listing, so it should be fine here as well.

we'll still need to look into the size issue

Yupp, please 😉 Per-ABI builds should take care of that I guess.

Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added metadata/en-US/images/phoneScreenshots/1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added metadata/en-US/images/phoneScreenshots/2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added metadata/en-US/images/phoneScreenshots/3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added metadata/en-US/images/tenInchScreenshots/1.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added metadata/en-US/images/tenInchScreenshots/2.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added metadata/en-US/images/tenInchScreenshots/3.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 1 addition & 0 deletions metadata/en-US/short_description.txt
thisconnect marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
All-in-one solution to securely manage your digital assets with ease
1 change: 1 addition & 0 deletions metadata/en-US/title.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
BitBoxApp
1 change: 1 addition & 0 deletions metadata/en-US/video.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
https://youtu.be/tQhw-QCtiyo